Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Rebase when pulling #493

Closed
Closed

Description

@simurai

When the local repo has unpushed commits and then doing a pull, it creates a merge commit, like this one:

screen shot 2017-01-27 at 8 04 03 pm

screen shot 2017-01-27 at 8 05 52 pm

Should it try to rebase instead? So that the history is kept clean? I think merge commits for PRs are fine, but when just pulling from the remote, it makes it a bit messy.

One day ™️ there could be a setting. Or like in Tower, a checkbox inline:

screen shot 2017-01-27 at 9 24 27 pm

But until then, use rebase as default?

Versions

GitHub Package Version (git --git-dir ~/.atom/packages/github/.git rev-parse head): c93a942

Activity

  1. smashwilson commented on Jan 27, 2017

    @smashwilson
    Contributor

    You can change when git pull performs a merge or a rebase with several git config settings, which this package should respect. I'd rather not override that logic if any users do have that configured manually for the CLI.

    In the long term, I'd ❤️ to see a way to show and set a merge vs. rebase config within the package UI backed by those same settings, like a checkbox that sets git config branch.<branchname>.rebase true. Maybe expose pull.rebase in some kind of repository settings panel, and branch.<branchname>.rebase in a branch settings panel... ?

  2. simurai commented on Jan 28, 2017

    @simurai
    ContributorAuthor

    I'd rather not override that logic if any users do have that configured manually for the CLI.

    I see. Yeah, that would be a bad idea. Ok, I added

    [pull]
    	rebase = true
    

    to my global .gitconfig for now.

  3. smashwilson commented on Apr 20, 2017

    @smashwilson
    Contributor

    Closing to prefer the user configuration workaround 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions