You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Repository navigation
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
UX Improvement: Staging/Unstaging files not obvious #336
NOTE: this is suggestion for maybe a user experience improvement, I don't think this should push back Staff ship or is needed to tackle right now.
When I first saw the UI, I thought you can drag and drop, or maybe hit down and up arrow, or right click to see a menu, but the only thing we can do is double click it(with right or left mouse click) to move the file up and down. Clicking Enter on the file does the same thing if it's selected.
If you click once(right or left click), you can view the file. My suggestion is right click should probably open a context menu with things you can do.
Yes, I can see that double-clicking could be hard to discover.
We could add checkboxes to make it more obvious. Then you could single click on a checkbox or double-click on the file name to stage/unstage. SourceTree does it like that.
A right-click context menu would be nice too. Maybe more for discarding the changes.
@50Wliu Maybe follow Github Desktop's example and get rid of the unstaged/staged sections, and just have a checkbox to indicate staged status?
Yeah, initially there used to be just a single list with checkboxes. And we reconsidered adding it back, but then decided against it.
If I recall correctly, it was because if a file is partially staged, in a single list you can't just use the ⬇️ ⬆️ arrow keys to move between unstaged/staged diff and there would need to be another way/keybinding to switch.
Activity
simurai commentedon Nov 29, 2016
Yes, I can see that double-clicking could be hard to discover.
We could add checkboxes to make it more obvious. Then you could single click on a checkbox or double-click on the file name to stage/unstage. SourceTree does it like that.
A right-click context menu would be nice too. Maybe more for discarding the changes.
winstliu commentedon Nov 29, 2016
Yes. I would love to be able to discard the changes.
Maybe follow Github Desktop's example and get rid of the unstaged/staged sections, and just have a checkbox to indicate staged status?
simurai commentedon Nov 29, 2016
Yeah, initially there used to be just a single list with checkboxes. And we reconsidered adding it back, but then decided against it.
If I recall correctly, it was because if a file is partially staged, in a single list you can't just use the ⬇️ ⬆️ arrow keys to move between unstaged/staged diff and there would need to be another way/keybinding to switch.