Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Rename config option for delay before opening FilePatchView #325

Closed

Description

@kuychaco

Come up with better name for the config option that specifies the amount of time to wait before opening a file diff while using keyboard nav in the changed file list (to avoid locking the UI when navigating past a large file diff)

Maybe something like this...
settings_ ___src_test-repo

reference: #318

Activity

  1. BinaryMuse commented on Jan 9, 2017

    @BinaryMuse
    Contributor

    @lee-dohm Do you have thoughts here, maybe to keep it consistent with other options? I rather like the description but the name could maybe use some work.

    It'd be awesome to nail down the setting name before staff ship since that's what get's written to config.{c,j}son

  2. BinaryMuse commented on Jan 9, 2017

    @BinaryMuse
    Contributor

    Also cc @smashwilson for 💭

  3. smashwilson commented on Jan 9, 2017

    @smashwilson
    Contributor

    How about just "Diff View Delay"?

    Naming things ¯\(ツ)/¯

  4. annthurium commented on Oct 2, 2018

    @annthurium

    this is now called "keyboard navigation delay" and I think that's good enough 😄

    going to close this out, feel free to reopen if you'd like to discuss further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions