This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Repository navigation
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Display loading indicator while FilePatchView is loading #323
Description
... so that the UI feels more responsive when displaying large diffs
Metadata
Metadata
Assignees
Labels
No labels
Activity
smashwilson commentedon Jan 7, 2017
I'll have a look at this next week! 😄
BinaryMuse commentedon Jan 7, 2017
I started working on this yesterday, but since the slow rendering is synchronous, it doesn't seem to help much. I tried a strategy to show the first couple hundred lines and then render the rest and it feels even slower. I'm not sure this is a good idea in hindsight
smashwilson commentedon Jan 7, 2017
Ah so it's actually the rendering speed that's the bottleneck, rather than computing and fetching and parsing the patch? Yeah, that feels like something that would be a lot easier to tackle once Fiber lands.
smashwilson commentedon Jan 7, 2017
(Assuming that my intuition about what Fiber does is correct, that is.)
BinaryMuse commentedon Jan 7, 2017
Yeah, is the synchronous DOM flushing from etch and the associated layout recalculation from showing the tab. Using a tiling strategy is the right thing but since we're moving to use the editor, which already does this, I don't think we should put forth the effort.