Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Parse diffs on demand for better performance #254

Closed

Description

@kuychaco

Currently we're unnecessarily parsing git diff output for all changed files when there is a file system change. That is, if we have 10 changed files and only one is modified, we get the diff output for all files, parse it, and create FilePatch objects for each of them when really we only need to do those things for the single file that changed.

To implement this we would check the nsfw change event to determine which file changed (if it's the index, we need to use the blob sha to determine which file changed) and only update the FilePatch corresponding to that file. Since on linux we can't watch entire directories (see #253), we may still want to periodically update all of the FilePatches.

Note: testing for this must be done on Mac, Windows, and Linux

Activity

  1. kuychaco commented on Sep 23, 2016

    @kuychaco
    ContributorAuthor

    This should address some of the slowness observed in #212 and possibly #201

  2. changed the title [-]Unnecessarily parsing diffs[/-] [+]Parse diffs on demand for better performance[/+] on Oct 5, 2016
  3. BinaryMuse commented on Jan 10, 2017

    @BinaryMuse
    Contributor

    Closed by #314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions