This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Repository navigation
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
(Un)staged changes does not use editor font size #1858
Description
Prerequisites
- Have you tried to reproduce the problem in Safe Mode?
- Have you followed all applicable steps in the debugging guide?
- Have you checked the FAQs on the message board for common solutions?
- Have you checked that your issue isn't already filed?
Description
The TextEditors used for the (un)staged changes view do not respect the editor font size I have configured.
It looks like this was noticed before with the old view in #331 and fixed in #333.
Steps to Reproduce
- Set the editor font size to anything other than 12
- Open (un)staged changes
- Compare to a normal text editor
Expected behavior: Font sizes to be identical
Actual behavior: Font sizes are different
Reproduces how often: 100%
Versions
You can get this information from copy and pasting the output of atom --version and apm --version from the command line. Also, please include the OS and what version of the OS you're running.
Atom : 1.35.0-dev-add03bdbe
Electron: 2.0.16
Chrome : 61.0.3163.100
Node : 8.9.3
Activity
simurai commentedon Dec 21, 2018
That's 😬 intended: 1390a6a
When adding the changed files #1829 to PRs, I felt that the default font size is too large. In that commit ☝️, the font size got locked to the font size of UI themes.
But I'll happily revert that commit again. An alternative could be that the file path and hunk titles use the UI font-size, but the diff/code use the font size from Atom's config. Like this:
winstliu commentedon Dec 21, 2018
Yeah, the difference is quite striking:
Maybe not that noticeable if the font sizes are off by just one or two, but by three it's hard not to notice.
This sounds like a good compromise 👍