This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Repository navigation
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Error when trying to view a pull request #1776
Description
Prerequisites
- Have you tried to reproduce the problem in Safe Mode?
- Have you followed all applicable steps in the debugging guide?
- Have you checked the FAQs on the message board for common solutions?
- Have you checked that your issue isn't already filed?
I even like asked on slack and they said come here.
Description
I went to checkout a pull request in my repository, however when I clicked on it, it failed to load.
Steps to Reproduce
These probably won't work, it's a unique situation
- Clone an repository with one open PR and open the project in atom.
- Open GH tab
- Click a pull request?? Not sure.
Expected behavior:
It to view the pull request as normal.
Actual behavior:
Both the github tab and main pane turn black and do nothing until I restart Atom.
Reproduces how often:
Only on one specific pull request. It did another from the same repository perfectly fine.
Versions
Versions? check it out
apm 2.1.2
npm 6.2.0
node 8.9.3 x64
atom 1.32.1
python 3.6.4
git 2.18.0
Additional Information
Here's a fun error I got.
<embedded>:14 TypeError: Cannot read property 'owner' of null
at BareIssueishDetailController.nextCheckoutOp (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:3679469)
at BareIssueishDetailController.render (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:3678190)
at Gg (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:2438932)
at Kg (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:2443812)
at th (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:2453366)
at uh (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:2453673)
at Rh (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:2457250)
at Uh (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:2456721)
at Sh (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:2456547)
at wh (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:2455920)
at kg (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:2455167)
at Object.enqueueSetState (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:2430758)
at ReactRelayQueryRenderer.F.setState (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:2356627)
at n.handleDataChange (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:3998669)
at ReactRelayQueryFetcher._onQueryDataAvailable (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:4149708)
at Object.next (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:4147379)
at Object.next (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:4168385)
at Object.next (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:4168385)
at Object.next (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:4167092)
at Object.next (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:4168385)
at Object.next (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:4168385)
at /Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:4170895
at _subscribe (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:4168783)
at RelayObservable.subscribe (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:4169034)
at Object.next (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:4169660)
at Object.next (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:4168385)
at Object.next (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:4168385)
at Object.next (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:4167092)
at Object.next (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:4168385)
at Object.next (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:4168385)
at /Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:4170895
at _subscribe (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:4168783)
at RelayObservable.subscribe (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:4169034)
at Object.next (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:4169660)
at Object.next (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:4168385)
at /Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:4170810
at <anonymous>
This error has occurred on my home mac and my work ubuntu laptop.
yes officer this specific pull request right here is the one causing me problems
Activity
smashwilson commentedon Nov 5, 2018
Ahh looks like we're assuming that some GraphQL node is required when it's actually nullable (... or the API changed). Thanks for the report, and also for giving us the specific pull request, that's super helpful 🙇
annthurium commentedon Nov 7, 2018
thanks @Chewsterchew for reporting! Working on a fix.
In the mean time, a workaround is to use the "open issue or pull request" command from the command palette, which for some reason works.
annthurium commentedon Dec 6, 2018
Just merged a fix, though it will take a bit for the fix to make its way from beta to stable.
I'm going to close, but feel free to reopen if there are additional issues or concerns.