Cursor should not be able to be placed after the last line of the diff #1760

Activity

1. Arcanemagus commented on Oct 25, 2018

   

   Arcanemagus

   on Oct 25, 2018

   More actions

   Copying here so you don't have to expand all the collapsed content to see it:

   ---

   This is relatively minor, but I just noticed you can place the cursor after the last line of the diff:
   

   Using this branch directly at 59b4b45, on Atom v1.33.0-nightly9.
2. annthurium commented on Oct 30, 2018

   

   annthurium

   on Oct 30, 2018

   More actions

   Once diffs are editable, it seems like we should allow you to put the cursor after the last line in case you want to extend the file, yes?
3. Arcanemagus commented on Oct 30, 2018

   

   Arcanemagus

   on Oct 30, 2018

   More actions

   That isn't the behavior when editing a file normally, so that doesn't make too much sense to me at least.

   There is a setting that allows you to scroll past the end of the file contents, but you can't place a cursor past the end of the contents. When we get to editable diffs they should match the regular editing experience as closely as possible.
4. smashwilson

   added

   papercutSmall-scope issues and bugs we can use to backfill our sprint plansSmall-scope issues and bugs we can use to backfill our sprint plans

   on Nov 16, 2018