This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Repository navigation
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Uncaught (in promise) TypeError: Cannot read property 'quietlySelectItem' of undefined #1399
Description
Prerequisites
- Have you tried to reproduce the problem in Safe Mode?
- Have you followed all applicable steps in the debugging guide?
- Have you checked the FAQs on the message board for common solutions?
- Have you checked that your issue isn't already filed?
Description
Right click on a file and choose view staged changes or view unstaged changes
Uncaught (in promise) TypeError: Cannot read property 'quietlySelectItem' of undefined
at GitTabController.quietlySelectItem (C:\Users\lineri\Desktop\issues\atom_master\atom\out\Atom x64\resources\app\node_modules\github\lib\controllers\git-tab-controller.js:470:34)
at RootController.quietlySelectItem (C:\Users\lineri\Desktop\issues\atom_master\atom\out\Atom x64\resources\app\node_modules\github\lib\controllers\root-controller.js:603:72)
at C:\Users\lineri\Desktop\issues\atom_master\atom\out\Atom x64\resources\app\node_modules\github\lib\controllers\root-controller.js:649:22
at Generator.next (<anonymous>)
at step (C:\Users\lineri\Desktop\issues\atom_master\atom\out\Atom x64\resources\app\node_modules\github\lib\controllers\root-controller.js:138:197)
at C:\Users\lineri\Desktop\issues\atom_master\atom\out\Atom x64\resources\app\node_modules\github\lib\controllers\root-controller.js:138:367
at <anonymous>
at process._tickCallback (internal/process/next_tick.js:109:7)
Steps to Reproduce
- Open Atom in safe mode
.\atom --safefromcmd.exeinatom/atom - Open
application-delegate.js - Right click on the file and pick view staged changes or view unstaged changes
Note: Same exception appears if you do this even where there are staged or unstaged changes.
Expected behavior:
Nothing to happen or a message that there are no staged or unstaged changes because there are none.
Actual behavior:
Exception in the console
Reproduces how often:
100%
Versions
Atom : 1.28.0-dev-603dc5a05
Electron: 1.7.11
Chrome : 58.0.3029.110
Node : 7.9.0
Additional Information
Related to #951 which is an exception when trying to view staged/unstaged changes on untitled buffers.
Activity
Remove obsolete `this.refs.gitTab` reference
smashwilson commentedon Apr 19, 2018
Fixed in 3b60042 directly on 0.14-releases and by #1390 on master. ✨
dwelle commentedon Apr 24, 2018
👍 any date on release of this fix?
Ben3eeE commentedon Apr 24, 2018
@dwelle The fix for this issue is currently scheduled to be included in the next beta hotfix.
dwelle commentedon Apr 27, 2018
No backport to stable? Will need to downgrade atom from zip file otherwise, since this bug makes this package very hard to use.
edit: can actually be "fixed" manually via
apm i github@0.14.2Remove obsolete `this.refs.gitTab` reference
smashwilson commentedon May 7, 2018
I didn't actually know this affected stable 😅
I've backported the fix to the 0.12 release line in 6b62f9c. I don't know if we're planning to do another hotfix of Atom 1.26 or not, but if we do it'll be there.
Remove obsolete `this.refs.gitTab` reference
Remove obsolete `this.refs.gitTab` reference