This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Repository navigation
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Hunks for staging are not visible in 'Unstaged Changes' tab #1074
Description
Description
When I select a file in the git panel it displays the existence of multiple hunks (only a line or two for each hunk) but does not display the hunk lines themselves.
The only 'non core' package I have not disabled at this point is emmet.
Expected behavior:
The screenshots I have seen showing the git integration seem to indicate I should see the actual modified lines.
Actual behavior:
The hunk 'data' is displayed but not the actual lines of code
Reproduces how often:
100%
Versions
Atom : 1.18.0
Electron: 1.3.15
Chrome : 52.0.2743.82
Node : 6.5.0
Ubuntu 16.04.3 LTS
Linux E6420 4.4.0-87-generic #110-Ubuntu SMP Tue Jul 18 12:55:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
Additional Information
Activity
BinaryMuse commentedon Aug 2, 2017
Hey @DavidCarpus — does this reproduce for you in Safe Mode?
DavidCarpus commentedon Aug 2, 2017
Yes.
BinaryMuse commentedon Aug 2, 2017
This is really interesting — I can see bits of green in the screenshot (added lines are colored in green) and some odd looking pixels to the left of the green that looks like it might be trying to display text? Wonder if it could be a font rendering thing.
@DavidCarpus If you open the developer tools and use the element selector, do you actually see the
HunkView-lineelements in the DOM? If so, does changing the font or font size help at all? I assume regular text editors appear normally?BinaryMuse commentedon Aug 2, 2017
Also: do you have any custom styles in your user stylesheet that might be affecting layout?
DavidCarpus commentedon Aug 2, 2017
I found a hunkview for some added text and it does indeed have a span in the DOM with the text.
Interestingly the font-size for .github-HunkView-line is 1px.
When I disable that particular style element the code shows up.
BinaryMuse commentedon Aug 7, 2017
Okay, thanks for digging into that. Looks like something weird is going on here with how we watch the editor font size setting.
DavidCarpus commentedon Aug 11, 2017
Not sure if needs to be logged separately or not but I tried to 'force' the font size by adding to my style.less but apparently the github-package-styles seems to be loaded later than the 'user' stylesheet?
DavidCarpus commentedon Dec 18, 2017
It appears at some point something was changed between 1.18.0 and 1.22.1 that appears to have fixed this.
.github-HunkView-line {font-size} now seems to be pulling the font size from the editor settings in preferences.
It might still be nice if the user stylesheet could override this setting but not nice enough at this point if it requires any significant re-architecture work.
simurai commentedon Jan 18, 2018
This seems like a bug and
styles.lessshould be loaded last. In the meantime you might can try to add a higher specificity. Like repeating the class name:or use
!important:that should override the styles from the github package even if loaded before.
kuychaco commentedon Jan 19, 2018
I'm going to go ahead and close this since the original issue has been resolved. I've opened a separate issue to capture the stylesheet priority issue (#1292)
Thanks for the report and help digging into this @DavidCarpus!