This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Repository navigation
Conversation
Add specs
Contributor
Author
|
Services won't work because only active packages can provide them but we want to show tips of not-yet-activated packages as well. |
fstiewitz
force-pushed
the
package-tips
branch
from
August 22, 2015 18:08
71d4fd7 to
925991e
Compare
Contributor
|
Why do you want to show tips of disabled packages? |
Author
|
I don't want to show tips of disabled packages. My second commit fixes the PR when On second thought, it might also be a good idea to better randomize the tips displayed, but I don't know if I should add that here or make a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would propably close #8
This PR would allow package devs to define their own tips in their package's
package.json: