Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Load tips from package.json - #20

Open
fstiewitz wants to merge 2 commits into
atom:masterfrom
fstiewitz:package-tips
Open

fstiewitz wants to merge 2 commits into
atom:masterfrom
fstiewitz:package-tips

Conversation

@fstiewitz

Copy link
Copy Markdown

Would propably close #8
This PR would allow package devs to define their own tips in their package's package.json:

"tips": [
  "Close panels like find and replace with {body>core:cancel}",
  "Everything Atom can do is in the Command Palette. See it by using {command-palette:toggle}",
  "You can quickly open files with the Fuzzy Finder. Try it by using {fuzzy-finder:toggle-file-finder}",
  "You can toggle the Tree View with {tree-view:toggle}",
  "You can focus the Tree View with {tree-view:toggle-focus}",
  "You can split a pane with {pane:split-right}",
  "You can jump to a method in the editor using {symbols-view:toggle-file-symbols}",
  "You can install packages and themes from the Settings View {settings-view:open}"
]

@benogle

benogle commented Aug 3, 2015

Copy link
Copy Markdown
Contributor

Using services might be a better approach for enabling #8

@fstiewitz

Copy link
Copy Markdown
Author

Services won't work because only active packages can provide them but we want to show tips of not-yet-activated packages as well.

@jerone

jerone commented Mar 25, 2016

Copy link
Copy Markdown
Contributor

Why do you want to show tips of disabled packages?

@fstiewitz

Copy link
Copy Markdown
Author

I don't want to show tips of disabled packages. My second commit fixes the PR when background-tips is disabled at start (which does not happen in a normal user environment but you never know).

On second thought, it might also be a good idea to better randomize the tips displayed, but I don't know if I should add that here or make a new PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow tips to be added via an API

3 participants