Repository navigation
Conversation
|
@fabn can you add a test for this?. Testing is something we need to improve. If it's not that difficult, it will be great to have some test coverage of this code |
This conversion is done by Transpec 3.3.0 with the following command:
transpec -f
* 38 conversions
from: obj.should
to: expect(obj).to
* 19 conversions
from: == expected
to: eq(expected)
* 6 conversions
from: obj.should_receive(:message)
to: expect(obj).to receive(:message)
* 4 conversions
from: it { should_not ... }
to: it { is_expected.not_to ... }
* 2 conversions
from: =~ /pattern/
to: match(/pattern/)
* 2 conversions
from: it { should ... }
to: it { is_expected.to ... }
* 1 conversion
from: obj.should_not_receive(:message)
to: expect(obj).not_to receive(:message)
* 1 conversion
from: obj.stub(:message)
to: allow(obj).to receive(:message)
For more details: https://github.com/yujinakayama/transpec#supported-conversions
…ng in travis until I found a working config for headless testing
|
@orlando I did that and much more but I din't receive any feedback. Could you please take a look into this? Thanks. |
|
@fabn Awesome!. I'll take a look today. Thank you for your patience |
|
@orlando a merge, maybe? |
| //= require jquery.ui.widget | ||
| //= require jquery.iframe-transport | ||
| //= require jquery.fileupload | ||
| //= require bootstrap-sprockets |
There was a problem hiding this comment.
@fabn I don't think we should introduce this dependency, let's keep the dummy app as barebones as possible
There was a problem hiding this comment.
@orlando that's a devo dependency that is not pulled when you add this gem as dependency. If I remember it's used in integration tests as js library to write some end to end tests but honestly I wrote this long time ago... I think is good to have e2e specs and dev dependency won't hurt gem itself.
|
Hey @sharq1, Sorry, I used to use this library in production but not anymore. I don't think I can review this change since is so big and includes things that are not necessary to have in the main repo (example |
|
I'm still using this gem (my fork) in a couple of production projects on rails 5.2 but now that activestorage is out and cloudinary support that natively I don't know if is still worth to maintain this gem. However if you're interested in merging this I can collaborate in my spare time. |
Will solve #138