Changes required for compiling in strict mode #1098

Activity

1. mcquiggd commented on Jul 8, 2017

   

   mcquiggd

   on Jul 8, 2017

   Last edited by mcquiggd

   More actions

   Even with strict mode turned off, I get these errors:

   ERROR in [at-loader] ./ClientApp/routes.tsx:9:12 
       TS2322: Type '{ exact: true; path: "/"; component: typeof Home; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<Route<T>> & Readonly<{ children?: ReactNode; }> & ...'.
     Type '{ exact: true; path: "/"; component: typeof Home; }' is not assignable to type 'Readonly<T>'.
   
   ERROR in [at-loader] ./ClientApp/routes.tsx:10:12 
       TS2322: Type '{ path: "/counter"; component: typeof Counter; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<Route<T>> & Readonly<{ children?: ReactNode; }> & ...'.
     Type '{ path: "/counter"; component: typeof Counter; }' is not assignable to type 'Readonly<T>'.
   
   ERROR in [at-loader] ./ClientApp/routes.tsx:11:12 
       TS2322: Type '{ path: "/fetchdata/:startDateIndex?"; component: typeof FetchData; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<Route<T>> & Readonly<{ children?: ReactNode; }> & ...'.
     Type '{ path: "/fetchdata/:startDateIndex?"; component: typeof FetchData; }' is not assignable to type 'Readonly<T>'.
   
2. stephtr commented on Jul 8, 2017

   

   stephtr

   on Jul 8, 2017

   Last edited by stephtr

   ContributorAuthor

   More actions

   These errors are independent from strict mode, therefore it would be better to create a new issue on github (see #1099). However I can confirm that these errors arise when creating a new project via yo.

   👍React with 👍2Reacted by Stephen Burns and Khiem-Kim Ho Xuan
3. SteveSandersonMS

   added this to the 2.0.0 milestone on Jul 11, 2017
5. varunpsr commented on Jul 12, 2017

   

   varunpsr

   on Jul 12, 2017

   More actions

   i don't face any issues while running restore or npm install however, when I run the application these are errors I get.

     ERROR in [at-loader] ./ClientApp/routes.tsx:10:12
         TS2322: Type '{ path: "/counter"; component: typeof Counter; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<Route<T>> & Readonly<{ children?: ReactNode; }> & ...'.
       Type '{ path: "/counter"; component: typeof Counter; }' is not assignable to type 'Readonly<T>'.
   
     ERROR in [at-loader] ./ClientApp/routes.tsx:11:12
         TS2322: Type '{ path: "/fetchdata/:startDateIndex?"; component: typeof FetchData; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<Route<T>> & Readonly<{ children?: ReactNode; }> & ...'.
       Type '{ path: "/fetchdata/:startDateIndex?"; component: typeof FetchData; }' is not assignable to type 'Readonly<T>'.
   
     ERROR in [at-loader] ./node_modules/@types/react-router/index.d.ts:67:21
         TS2694: Namespace 'React' has no exported member 'ComponentType'.
   
     ERROR in [at-loader] ./node_modules/@types/react-router/index.d.ts:102:48
         TS2694: Namespace 'React' has no exported member 'ComponentType'.
     Child extract-text-webpack-plugin:
         chunk    {0} extract-text-webpack-plugin-output-filename 4.08 kB [entry] [rendered]
             [0] ./~/css-loader/lib/css-base.js 2.26 kB {0} [built]
             [1] ./~/css-loader!./ClientApp/css/site.css 1.82 kB {0} [built]
   

   `
6. stephtr

   changed the title [-]ReactRedux template doesn't compile in strict mode[/-] [+]Changes required for compiling in strict mode[/+] on Jul 12, 2017
7. stephtr commented on Jul 12, 2017

   

   stephtr

   on Jul 12, 2017

   ContributorAuthor

   More actions

   As I mentioned that has nothing to do with this issue. In #1099 a temporary workaround has been posted:
   Update your package.json file to:

       ...
       "@types/react": "15.0.35",
       "@types/react-dom": "15.5.1",
       "@types/react-redux": "4.4.45",
       "@types/react-router-dom": "4.0.6",
       "@types/react-router-redux": "5.0.3",
       ...
       "typescript": "2.3.4",
   

   Afterwards you just have to restore the packages, then the ReactRedux template should work again.

   👍React with 👍6Reacted by Edson Alcalá, Erik Boeters, Chun Liu, Mahmoud Samy, tedro and Joonas Westlin
8. SteveSandersonMS commented on Jul 13, 2017

   

   SteveSandersonMS

   on Jul 13, 2017

   Member

   More actions

   Thanks @stephtr for the pull request. That's now merged, so this issue is fixed.

   Also, strict mode is now enabled in all the templates by default. I can't think of much of a reason people would want to avoid that, but if they do, it's much easier to turn off than to turn on.

   👍React with 👍1Reacted by Stephan Troyer
9. SteveSandersonMS

   closed this as completedon Jul 13, 2017
10. varunpsr commented on Jul 13, 2017

    

    varunpsr

    on Jul 13, 2017

    More actions

    Awesome, thank you! 👍