Skip to content

SIFT memory leak #169

Open
Open
SIFT memory leak#169

Description

@tomerdmnt
tomerdmnt
opened on Dec 24, 2017

It seems that the SIFT detection leaks memory. Here is the example script I am running.

import arrayfire as af
import time

while True:
    im = af.load_image('image.jpg')
    feats, desc = af.vision.sift(im)

    af.device.device_gc()
    af.print_mem_info()
    time.sleep(1)

I solved part of the leaks in #168. Apparently the features destructor wasn't called, and af_release_features needed to be called explicitly from python.

With this fix the ORB feature detection works without leaks, but SIFT and GLOH still do.

Running pretty much the same methods in C works without a memory leak. So I think there might be another destructor that ought to be called explicitly, just like af_release_features, but I could not figure out where the leak was originated from.

Activity

  1. tomerdmnt commented on Jan 15, 2018

    @tomerdmnt
    tomerdmnt
    on Jan 15, 2018
    ContributorAuthor

    Somewhat related to this, after getting an array from a feature, say xpos = feature.get_xpos(), there is a double free bug, because the array is cleaned when af_release_features is called in the feature's __del__ and also in the array __del__ method.

    Right now, I work around it by setting xpos.arr.value = 0 before the destructors are called.

    It's possible to fix this by getting the feature to save a reference to all its arrays, and cleaning them properly. Do you think is a reasonable fix? I'd be happy to open a pull request for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions