Repository navigation
HttpClient: Fix hanging up post request with large request body - #206
Open
takayoshi-k wants to merge 1 commit into
Open
takayoshi-k wants to merge 1 commit into
takayoshi-k wants to merge 1 commit into
Conversation
When post() is called with a large request body, startRequest() does not check the return value of write(). Since write() delegates to the underlying socket client's write() method, it may write fewer bytes than requested. If a partial write occurs, the HTTP connection may hang because the server continues waiting for the remaining data.
|
|
|
Memory usage change @ 9c2b396
Click for full report table
Click for full report CSV |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When post() is called with a large request body, startRequest() does not check the return value of write(). Since write() delegates to the underlying socket client's write() method, it may write fewer bytes than requested. If a partial write occurs, the HTTP connection may hang because the server continues waiting for the remaining data.