You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Okay I must have forgotten about this. Closing.
Reopen if there are there relevant todos left on this.
For example something I've encountered in other projects that is nice is the ability for people issuing PRs to run the CI and have the results show up in the PR chat. But we don't have enough tests that they couldn't be run locally so that isn't a big advantage at this point.
I think we can set that up through branch protection rules. I've
contemplated kickin those on to at least prevent direct commits to master
without going through a PR first. I'll look into setting up the status
check system.
On Wed, Dec 9, 2020 at 11:22 AM DannyWeitekamp ***@***.***> wrote:
Okay I must have forgotten about this. Closing.
Reopen if there are there relevant todos left on this.
For example something I've encountered in other projects that is nice is
the ability for people issuing PRs to run the CI and have the results show
up in the PR chat. But we don't have enough tests that they couldn't be run
locally so that isn't a big advantage at this point.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#74 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIADH4EOX65ZWKBKHH3EYLST6P4FANCNFSM4USR4RFQ>
.
--
Erik Harpstead
Systems Scientist
Human-Computer Interaction Institute
Carnegie Mellon University
harpstead@cmu.edu
Activity
eharpste commentedon Dec 9, 2020
We do have Travis-CI setup already (https://travis-ci.org/github/apprenticelearner/AL_Core), which also connects to Coveralls (https://coveralls.io/github/apprenticelearner/AL_Core). Happy to use something else if someone wants to take point on setting it up.
DannyWeitekamp commentedon Dec 9, 2020
Okay I must have forgotten about this. Closing.
Reopen if there are there relevant todos left on this.
For example something I've encountered in other projects that is nice is the ability for people issuing PRs to run the CI and have the results show up in the PR chat. But we don't have enough tests that they couldn't be run locally so that isn't a big advantage at this point.
eharpste commentedon Dec 9, 2020