Repository navigation
Set custom interop type names via attribute instead of static property - #89
Closed
PeterCurry wants to merge 2 commits into
Closed
PeterCurry wants to merge 2 commits into
PeterCurry wants to merge 2 commits into
Conversation
Change NSObject.GetInteropTypeName to ceck for InteropTypeNameAttribute instead of looking for static InteropTypeName proprety.
pull Bot
pushed a commit
to 16CentAstrology/unityplugins
that referenced
this pull request
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal & Changes
NSObject.GetInteropTypeNameattempts to derive the Objective-C class name that a C# type is wrapping by directly converting the name, which does not work for nested types such asGKLeaderboard.Entry. This could be overridden by means of a static property on the class namedInteropTypeName, but because this was checked via reflection, it could easily be code-stripped and proved unreliable in builds.To make this less reliant on reflection and more reliable, I've changed the technique to use a new attribute (
InteropTypeNameAttribute) instead of a static property.NSObject.GetInteropTypeNamenow checks for the attribute instead of a static property. The one place this was used in the library (GKLeaderboard.Entry) has been updated.