Repository navigation
K2GO-550 fix(sync): parse the rsync 3.5.2 progress line - #749
Merged
Merged
Conversation
rsync 3.5.2 writes the progress2 byte column with a "B" unit, so no line matched and Clone showed 0% with no speed or ETA.
Fix the parser header comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
RsyncProgressaccepts an optional "B" unit after the progress2 byte column. New unit test for the 3.5.2 format.Why
122,191,872B 58% 122MB/s 0:00:00. No line matched, so the Clone receive screen showed 0% with no speed or ETA. The transfer itself was fine.Verifications
RsyncProgressTestgreen (old and new formats).librsync.so.Notes
--statstotal line is unchanged in 3.5.2.