Repository navigation
ADFA-352| Update app name, icons, and hash files - #43
Merged
Merged
Conversation
- Changed the app name to "Code on the Go". - Updated the notification icon to use `ic_launcher_fg_vector`. - Updated the splash screen animated icon to use `ic_launcher_foreground`. - Updated the document provider root icon to use `ic_launcher_foreground`. - Updated hash files `CoGoTooltips` and `LayoutEditor`.
alome007
approved these changes
Mar 31, 2025
jatezzz
pushed a commit
that referenced
this pull request
Jun 22, 2026
ADFA-352| Update app name, icons, and hash files
davidschachterADFA
added a commit
that referenced
this pull request
Oct 18, 2026
From the independent review of PR #2162: - R2162-01: the rule ran inside the raw-path lookup, so a raw form that rendered kept a stored jstopics row under the percent-decoded form from being found. lookupRequestPath now tries both stored forms first and renders only after both miss; lookup() reads stored rows only. - R2162-02: a duplicated page row is reported as Ambiguous, as the page itself is, rather than as a quiet 404. - R2162-03: tests for a Brotli-compressed page (bytes marked brotli that are not fail the decode instead of rendering) and for a page split across rows. - R2162-05: the template check uses DatabaseTemplateLoader's resourceExists, and reading and decoding a row is one helper shared by both callers. - R2162-06: the rule applies only to a page rendered through helpmanual-topic.peb, so another doc set's jstopics path stays a 404. - R2162-07: the docs no longer call templated rows only the Kotlin doc set's pages, and name both Help+Manual templates. R2162-04 belongs to OfflineDocumentationTools PR #43. Tests: DocumentationContentSourceTest goes through lookupRequestPath, the lookup both transports make; five new cases. Breaking each new guard fails the test named for it: the rule before the decoded lookup, a quiet duplicate, any page template, no template check, no Brotli decode, the first chunk only. :common has 216 tests passing, and spotlessCheck passes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018CMZQuXT3GT7nEct2w4tg3
hal-eisen-adfa
added a commit
that referenced
this pull request
Oct 23, 2026
…2162) * ADFA-6618: Render a Help+Manual topic's jstopics file from its page Help+Manual's in-page navigation loads jstopics/X.js, a JavaScript copy of topic X. The documentation pipeline is to store each topic once, as the JSON its page X.html renders from through a Pebble template, and drop these copies (OfflineDocumentationTools PR #43). So a lookup that finds no row for a path of the form [dir/]jstopics/X.js now renders the helpmanual-jstopic.peb template with the JSON of [dir/]X.html and serves it as text/javascript. A stored jstopics row still wins, and the miss stays a 404 when the page is not a single templated row, has no row, or the database has no such template. Tests: six new cases in DocumentationContentSourceTest. Breaking each guard in turn fails the test named for it: no rule, no template check, no templateId check, a regex that accepts subfolders, the wrong MIME type. :common has 211 tests passing, and spotlessCheck passes. docs/documentation-database.md describes the rule beside the other template rendering. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018CMZQuXT3GT7nEct2w4tg3 * ADFA-6618: Answer the PR #2162 review From the independent review of PR #2162: - R2162-01: the rule ran inside the raw-path lookup, so a raw form that rendered kept a stored jstopics row under the percent-decoded form from being found. lookupRequestPath now tries both stored forms first and renders only after both miss; lookup() reads stored rows only. - R2162-02: a duplicated page row is reported as Ambiguous, as the page itself is, rather than as a quiet 404. - R2162-03: tests for a Brotli-compressed page (bytes marked brotli that are not fail the decode instead of rendering) and for a page split across rows. - R2162-05: the template check uses DatabaseTemplateLoader's resourceExists, and reading and decoding a row is one helper shared by both callers. - R2162-06: the rule applies only to a page rendered through helpmanual-topic.peb, so another doc set's jstopics path stays a 404. - R2162-07: the docs no longer call templated rows only the Kotlin doc set's pages, and name both Help+Manual templates. R2162-04 belongs to OfflineDocumentationTools PR #43. Tests: DocumentationContentSourceTest goes through lookupRequestPath, the lookup both transports make; five new cases. Breaking each new guard fails the test named for it: the rule before the decoded lookup, a quiet duplicate, any page template, no template check, no Brotli decode, the first chunk only. :common has 216 tests passing, and spotlessCheck passes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018CMZQuXT3GT7nEct2w4tg3 * ADFA-6618: Report a duplicated topic page under the page's path From CodeRabbit's review of PR #2162: a duplicated i/X.html row made a request for i/jstopics/X.js return Ambiguous under the jstopics path. WebServer quotes that path in its "Corrupt database" answer so that a bug report carries a query reproducing the duplicate, and the jstopics path has no rows at all. lookupJsTopic now returns the page's path with an Ambiguous result; other results keep the requested path. The duplicated-page test now also checks the reported path, and fails with the path left as the jstopics one. :common has 216 tests passing, and spotlessCheck passes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018CMZQuXT3GT7nEct2w4tg3 * ADFA-6618: Test the decoded-form and Brotli renders From the independent review of 36c2838 and ea8976a: - R2162-08: a test renders a jstopics file from a page found only under the percent-decoded path (i/a b.html for i/jstopics/a%20b.js). - R2162-09: lookupRequestPath's KDoc names the jstopics rule it now owns, and that a duplicated page is reported under the page's path. And CodeRabbit's nitpick on R2162-03: no test decoded a valid Brotli row through DocumentationContentSource, so a decode that always failed passed every test. :common's tests can't load brotli4j's desktop native, so BrotliContentSourceTest in :app serves a stored Brotli row and renders a jstopics file from a Brotli page. Breaking each fails the test named for it: dropping the decoded-form render fails the new :common test; a decode that always throws fails both BrotliContentSourceTest cases. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018CMZQuXT3GT7nEct2w4tg3 * ADFA-6618: Pass the database to renderNamed, as #2164 does #2164 gives renderNamed a database parameter. Taking it here, with the same lines, keeps renderJsTopic compiling whichever of the two lands second. --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Hal Eisen <haleisen@appdevforall.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This update rebrands the app to "Code on the Go" by changing its name, refreshing the notification and splash screen icons, and updating the document provider root icon. Additionally, hash files for CoGoTooltips and LayoutEditor have been revised for improved consistency.
Details
Ticket
ADFA-352
Observation