Repository navigation
ADFA-6944: Skip apt when jq is already installed - #2224
Open
Daniel-ADFA wants to merge 1 commit into
Open
Daniel-ADFA wants to merge 1 commit into
Daniel-ADFA wants to merge 1 commit into
Conversation
The v7 and v8 release jobs can run on the same self-hosted machine and reach "Install jq" together. apt lets one process hold its lock, so the second job failed and skipped its Slack and Telegram posts. jq is already on the runners, so check for it first, as the advzip step does. debug.yml had the same step.
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADFA-6944
The nightly 64-bit job failed at "Install jq" (run): both release jobs ran on the same machine and called
apt-get updateat the same second, so one could not get the apt lock. jq is already installed on the runners.The "Install jq" step in
release.ymlanddebug.ymlnow skips apt when jq is present, as the advzip step already does.