Skip to content

ADFA-6944: Skip apt when jq is already installed - #2224

Open
Daniel-ADFA wants to merge 1 commit into
stagefrom
fix/ADFA-6944
Open

Daniel-ADFA wants to merge 1 commit into
stagefrom
fix/ADFA-6944

Conversation

@Daniel-ADFA

@Daniel-ADFA Daniel-ADFA commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

ADFA-6944

The nightly 64-bit job failed at "Install jq" (run): both release jobs ran on the same machine and called apt-get update at the same second, so one could not get the apt lock. jq is already installed on the runners.

The "Install jq" step in release.yml and debug.yml now skips apt when jq is present, as the advzip step already does.

The v7 and v8 release jobs can run on the same self-hosted machine
and reach "Install jq" together. apt lets one process hold its lock,
so the second job failed and skipped its Slack and Telegram posts.
jq is already on the runners, so check for it first, as the advzip
step does. debug.yml had the same step.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai

coderabbitai Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Summary

  • In .github/workflows/debug.yml and .github/workflows/release.yml, check for jq before installing it. Run apt-get update and install jq only when it is absent.
  • This reduces unnecessary package operations when concurrent jobs share a machine.
  • Risk: The workflows assume any jq found on the runner is suitable. CI and test results are not available.

The debug and release workflows now check whether jq is available before running package-manager commands. They update package lists and install jq only when it is absent.

Changes: Conditional jq Installation

Layer / File(s) Summary
Workflow jq installation checks
.github/workflows/debug.yml, .github/workflows/release.yml
Both workflows skip package-list updates and installation when jq is already available. If it is absent, they run the installation commands.

Estimated code review effort: 2 (Simple) | ~8 minutes

Suggested reviewers: hal-eisen-adfa

Merge Risk: Minimal · up to d0c8d

The workflows are intended to avoid apt when jq is already installed. No merge-blocking risk is identified from the supplied evidence.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title names the primary change: the "Install jq" step now skips apt when jq is already installed. It matches the summary, which says both workflows check for jq before running apt-get update and i…
Description check Passed The description links ticket ADFA-6944 and explains the failure. A nightly 64-bit job failed when two release jobs called apt-get update at the same time and one could not get the apt lock. It states …
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the primary change: the "Install jq" step now skips apt when jq is already installed. It matches the summary, which says both workflows check for jq before running apt-get update and install. The ticket prefix is an identifier, not noise, and the title is specific enough for a teammate scanning history.

Full details: Description check

Explanation

The description links ticket ADFA-6944 and explains the failure. A nightly 64-bit job failed when two release jobs called apt-get update at the same time and one could not get the apt lock. It states that the 'Install jq' steps in release.yml and debug.yml now skip apt when jq is present. This matches the changeset.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks the tool in place,
Then skips the install at a steady pace.
If jq is gone, the lists update,
And both workflows install it straight.
The debug path and release run,
Now check before the work is done.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 9a3ab662-050c-4b63-821e-e84899aaedfc
Commits

Reviewing files that changed from the base of the PR and between ffaa75b and d0c8d46.

Files selected for processing: 2

  • .github/workflows/debug.yml
  • .github/workflows/release.yml

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

@Daniel-ADFA
Daniel-ADFA requested a review from a team November 5, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant