Repository navigation
ADFA-6560: Restore plugin-api constructors that older plugins call - #2173
Conversation
…change Editing the file pulls it under the Spotless ratchet, which reindents it to tabs and adds trailing commas. Kept separate from the ADFA-6560 fix.
#1268 added directPath to PluginTooltipButton, which replaced the (String, String, int) constructor. Plugins built before it, such as older Keystore Generator installs, call that constructor from getTooltipEntries, so their documentation install fails with NoSuchMethodError on every launch (fatal on older releases). Add the old constructor back as a hidden secondary constructor. It restores both (String, String, int) and its default-order synthetic, while staying invisible to Kotlin source, so current callers resolve to the primary constructor as before.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 42.42% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 33 functions across 8 files. (2 skipped: … | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Title check The title clearly identifies the restoration of plugin-api constructors for older plugins. This is a central change in the pull request, although it does not mention the Java default-method compatibil… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Description check The pull request description directly addresses the changeset. It explains Java default methods, restored plugin compatibility constructors, default-argument helpers, affected plugin versions, and for… Full details: Title check
-
Explanation
The title clearly identifies the restoration of plugin-api constructors for older plugins. This is a central change in the pull request, although it does not mention the Java default-method compatibility work.
Full details: Description check
-
Explanation
The pull request description directly addresses the changeset. It explains Java default methods, restored plugin compatibility constructors, default-argument helpers, affected plugin versions, and formatting-only commits.
-
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 42.42% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 33 functions across 8 files. (2 skipped: 2 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
✨ Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
A rabbit checks each default door,
Old constructors hop back once more.
JVM methods bloom in place,
Tests guard every bridge and case,
Version notes mark the floor.
Comment @coderabbitai help to get the list of available commands.
…no functional change Editing both files pulls them under the Spotless ratchet. Kept separate from the ADFA-6560 fix.
NavigationItem, TabItem, FileTabMenuItem and MenuItem gained tooltipTag (MenuItem also icon) after April, which replaced the constructors that plugins built before then call. An old Keystore Generator build still failed on NavigationItem's constructor in getSideMenuItems after the PluginTooltipButton fix. Add the old constructors back as hidden secondary constructors. NavigationItem, TabItem and FileTabMenuItem take the old parameters with the old defaults, which restores both the full constructor and its default-argument synthetic. MenuItem's full constructor survived through @jvmoverloads, so only its default-argument constructor is restored, with the exact JVM signature and the April defaults applied from the mask.
Daniel-ADFA
changed the title
Pinning languageVersion to 2.1 (ADFA-4058, later 2.0) dropped Kotlin's newer jvm-default behaviour, so plugin-api compiled every interface body as an abstract method plus a DefaultImpls static. Plugins built against the earlier plugin-api call the interface default with invoke-super. The April Keystore Generator, for one, hit AbstractMethodError on UIExtension.getToolbarActions() in EditorActivity.onCreate. The plugin crash guard caught it, but the editor stayed blank until the plugin was disabled. jvmDefault = ENABLE keeps the language pin and puts the bodies back on the interfaces. It keeps DefaultImpls for plugins built since May, and restores the IdeArchiveService.extract$default and IdeCommandService.executeCommand$default helpers that pre-May callers link against. A plugin built against this plugin-api has no DefaultImpls stubs, so on an IDE built between ADFA-4058 and 26.42 it needs to override every interface method it uses. PLUGIN_API_CHANGELOG.md says so. InterfaceDefaultMethodsTest fails without the change: getToolbarActions is not a default method, and neither is any body behind a DefaultImpls static. fragment-ktx joins the test runtime classpath because EditorTabExtension takes a Fragment and reflection has to load it.
ADFA-6560
Makes it safe to add methods with a default body to plugin interfaces, and lets plugins built before May load again.
jvmDefault = ENABLE). Since the ADFA-4058languageVersionpin they were abstract methods plusDefaultImpls. So each method with a body added to an interface a plugin implements failed withAbstractMethodErrorin every plugin built before it, unless the host wrapped the call (asPluginUiActionManagerdoes forgetHiddenToolbarActionIds). Those plugins now inherit the body.DefaultImplsstays, so plugins built since May are unaffected.PluginTooltipButton(String, String, int)(Add plugin sidebar/toolbar tooltips and directPath URI option #1268), the pre-tooltipTagconstructors ofNavigationItem,TabItem,FileTabMenuItemandMenuItem(hidden from Kotlin source), and theIdeArchiveService.extractandIdeCommandService.executeCommanddefault-argument helpers. The April Keystore Generator build behind GlitchTip 8548737 works again. The builds on addons.appdevforall.org were never affected.A plugin built against this plugin-api needs IDE 26.43 or later unless it overrides every interface method it implements (noted in PLUGIN_API_CHANGELOG.md). The two
style:commits are Spotless reformats only.