Skip to content

ADFA-3771: Remove android-sdk.zip image recompression doc - #1629

Merged
hal-eisen-adfa merged 1 commit into
stagefrom
chore/ADFA-3771-remove-recompression-doc
Aug 4, 2026
Merged

hal-eisen-adfa merged 1 commit into
stagefrom
chore/ADFA-3771-remove-recompression-doc

Conversation

@hal-eisen-adfa

Copy link
Copy Markdown
Collaborator

Deletes docs/process/recompress-android-sdk-images.md, added in #1602.

The runbook documents a procedure that does not belong in this repo. It describes rewriting the locally downloaded, gitignored copies under assets/ — a dead end, since the published android-sdk-*.zip assets are built and shipped from appdevforall/dev-assets (PR #50). Following it changes nothing users ever download.

Nothing in the repo references the file (git grep recompress-android-sdk-images on stage: no hits), and no commit has touched it since it merged.

Scope: docs-only, -73/+0, one file. No code, build logic, or shipped asset is affected — the image size savings described in the doc live in dev-assets and are unaffected by this deletion.

Chose a plain deletion over git revert so the commit states why the doc is going away; there are no dependents that make the revert lineage worth preserving.

Deletes docs/process/recompress-android-sdk-images.md, added in #1602.

The runbook documents a procedure that does not belong in this repo. It
describes rewriting the locally downloaded, gitignored copies under assets/,
which is a dead end -- the published android-sdk.zip assets are built and
shipped from appdevforall/dev-assets (PR #50), so following it changes
nothing users ever download. Nothing in the repo references the file.

Docs-only; no code, build logic, or shipped asset is affected.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 16863c7b-2b36-4a2a-9db6-5bf859009a61

📥 Commits

Reviewing files that changed from the base of the PR and between 7439153 and 9fa58c4.

📒 Files selected for processing (1)
  • docs/process/recompress-android-sdk-images.md
💤 Files with no reviewable changes (1)
  • docs/process/recompress-android-sdk-images.md

📝 Walkthrough
  • Remove the obsolete Android SDK image recompression runbook.
  • Published android-sdk-*.zip assets remain unaffected because appdevforall/dev-assets builds and ships them.
  • No code, build logic, or shipped assets changed.
  • Risk: contributors who need to recompress local SDK images no longer have this repository procedure.

Walkthrough

The pull request removes the Android SDK image recompression process document. No public declarations changed.

Changes

Cohort / File(s) Summary
Documentation cleanup
docs/process/recompress-android-sdk-images.md
Removes the procedure for recompressing Android SDK ZIP assets and verifying the resulting archives.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Poem

A rabbit hops past the vanished guide,
PNGs and ZIPs now rest inside.
No public names were changed today,
One process page has left the way.
Hop, hop—clean docs hold sway!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the deletion of the Android SDK image recompression documentation.
Description check ✅ Passed The description explains why the documentation is being removed and accurately states the docs-only scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/ADFA-3771-remove-recompression-doc

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hal-eisen-adfa
hal-eisen-adfa merged commit e429548 into stage Aug 4, 2026
4 checks passed
@hal-eisen-adfa
hal-eisen-adfa deleted the chore/ADFA-3771-remove-recompression-doc branch August 4, 2026 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant