Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found with a differential run of
XmlObject.validate(),ValidatingXMLStreamReaderand the JDK Xerces validator over the same schemas and instances. Only the stream reader disagreed, and only when the root element carried an xsi attribute.validate_eventcreates the Validator on the first START_ELEMENT and sends two BEGIN events: one for the type it was started with (the document type fromtypeForGlobalElement, or the caller's content type), then one for the element. Both passed_elemEvent, whosegetXsiType/getXsiNilread the current element's attributes.Validator.beginEventtherefore checked the root's xsi:type and xsi:nil against the document type. A document type is never the base of a named type and has no nillable field._eatContentat document level. Nothing else in the document is validated, and the facets of the xsi:type are never applied.The root BEGIN now uses
_simpleEvent, which carries no xsi attributes. The CHARACTERS-first path andpushBufferedAttributesalready start the validator that way. After the change the differential run has no stream-reader-only disagreement left. Regression tests added toValidatingXMLStreamReaderTests; they fail before the change and pass after. Full./gradlew testpasses.