Repository navigation
[python] Filter shard reads and _ROW_ID reads after selecting rows - #11024
Merged
JingsongLi merged 1 commit intoNov 10, 2026
Merged
Conversation
Contributor
Author
|
Thank you @JingsongLi and @Akash3121 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
close #11023
With a filter,
with_shardandwith_slicereturn rows that belong to another shard, and a filtered read of_ROW_IDon a row-tracking table returns renumbered_ROW_IDs. The issue has the repro. Both count the rows the format reader returns, and the format reader has already applied the pushed-down filter.file_reader_supplierno longer pushes the filter into the format reader when it reads a shard range or the read assigns_ROW_ID, as it already does for deletion vectors and physical row ranges.RawFileSplitReadapplies the filter to those reads after the rows are selected. Reads without a shard and without_ROW_IDstill push the filter down.#10723 changes the same condition in
create_readerfor Vortex files; it does not touch shard or_ROW_IDreads.Tests
read_predicate_positions_test.py, all failing on master:INfilter each return only their own row,with_slice(0, 5)returns only the row inside the slice, and a filtered read of_ROW_IDon a row-tracking table returns the rows' own ids._ROW_IDs in each shard.