[python] Avoid Bloom false negatives for floating-point BTree keys - #10364
Open
TheR1sing3un wants to merge 1 commit into
Open
TheR1sing3un wants to merge 1 commit into
TheR1sing3un wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Python's floating-point BTree comparator treats different NaN payloads as equal, and likewise treats positive and negative zero as equal. The optional Bloom filter hashes serialized bytes, so equality/IN queries using an equivalent value with different bytes can incorrectly return no rows.
Route NaN and zero point queries through the existing comparator-based range lookup. This preserves current comparison semantics and supports already-written indexes without changing key encodings or the file format. Other point queries retain the Bloom fast path.
Tests
btree_bloom_filter_test.py: 12 passed, including the existing assertion that missing ordinary keys read only the Bloom filter. Seven new cases fail against the unchanged base; one signed-zero case happens to be a Bloom false positive.btree_thread_safety_test.pyandglobal_index_build_test.py: 47 passed.git diff --checkpass.