Repository navigation
refactor(table): extract file store factories - #516
Merged
Merged
Conversation
Centralize path, snapshot, manifest, index and partition component construction in an operation-local FileStore. Preserve existing option parsing, validation, dispatch and commit behavior.
lszskye
reviewed
Nov 6, 2026
lszskye
reviewed
Nov 6, 2026
lszskye
reviewed
Nov 6, 2026
lszskye
reviewed
Nov 6, 2026
This was referenced Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Related issue: #459. First split from #447; this PR contains only the component-factory extraction.
Managed-table scan, read, write and commit construction repeats path, snapshot, manifest and index setup inside
table.cpp. Extract that setup into an internal, operation-localFileStore, so the existing entry points delegate component construction without changing their loading or execution flow.Scope: 4 files, 267 insertions and 131 deletions:
src/paimon/core/table/file_store.h/.cppwith factories for paths, snapshot managers, manifest lists/files, index manifests/handlers and partition computers.table.cpp, preserving the selected branch, bucket mode, physical format, filesystem, cache and resource arguments.FileStorereceives already resolved options and is local to each operation. It does not load schemas, parse options, cache managers, or become a member ofTable. The existing nineCoreOptions::FromMapcalls and six schema-validation calls remain unchanged and in the same order. Catalog snapshot loaders retain shared ownership of their catalog.This PR does not include the Table hierarchy, Context/API changes, schema getter rename, Copy/time-travel fixes, or the proposed ExecutionContext/CatalogEnvironment design.
Tests
Local Debug/AddressSanitizer build with REST, Lance, Mosaic, ORC, Avro and Vortex enabled:
git diff --checkpassed.Commands:
Existing behavior tests are retained without caller migration; no implementation-mirroring factory tests are added.
API and Format
No public API, storage format or wire protocol changes.
Tableremains concrete, existing Contexts and static factory signatures remain unchanged, and format/system-table dispatch stays in place. Option parsing, validation, schema loading, commit selection and Copy behavior are outside this extraction.Documentation
No user-facing feature is introduced. The new internal class documents its operation-local factory role; user documentation does not change.
Generative AI tooling
Generated-by: OpenAI Codex (GPT-6)