Repository navigation
Conversation
…d configs The source release ships verbatim or lightly edited copies of manifests and configuration files from cert-manager, ingress-nginx, Kubegres, Milvus Operator, Milvus and its Helm chart (with the rendered Pulsar, Bitnami etcd and MinIO charts), the MongoDB Community Operator, the Prometheus community chart and Apache Kvrocks. All are Apache-2.0 but none were listed in the top-level LICENSE. List them with their upstream locations and versions, and propagate the NOTICE attribution for the two ASF upstreams (Pulsar, Kvrocks). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
|
actually minio and mongodb has been removed from the distribution so it is better to remove them |
Member
Author
|
This is not a blocker for me but we need to fixed before we do a future release. If we merge this and remove the minio and mongodb LICENSE bits when we remove them from the release build - would that be ok? |
Contributor
|
I am not merging this PR because we plan to clean the code first removing unnecessary and obsolete dependencies - work is already started by the community members to clean them |
Member
Author
|
If any of these files are retained, the LICENSE and NOTICE will need to updated to mention the ones that are retained. |
Contributor
|
managed after cleaning the code |
This was referenced Sep 30, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the third-party Kubernetes manifests and configuration files that the source release physically ships to the top-level
LICENSE, and propagates theNOTICEattribution for the two ASF upstreams among them.Found while verifying the 0.9.0-incubating RC5 source tarball. None of these were mentioned in the top-level
LICENSE, whose "Bundled components" section only listed OpenWhisk, Spray and the Gradle wrapper. Theoplugins-op/LICENSEonly says the manifests reference third-party images; it does not say the manifest text itself is copied from upstream.Files covered
Every upstream was verified by diffing the shipped file (ASF header removed) against the upstream artefact at the tag stated. All are Apache License 2.0.
cert-manager.yamldeploy/static/provider/*with 0–58 lines of local editskubegres-crd.yamltesting/copy is an older buildCopyright (C) 2019-2021 Zillizkvrocks.confwith 16 lines of local editsNon-Apache licences: none found, two things worth knowing
milvus_manifest.yaml): the chart templates are Apache-2.0. They were published by MinIO before its April 2021 switch to AGPL-3.0 and are redistributed by milvus-helm under that repo's Apache-2.0 licence. The MinIO server image is AGPL-3.0 but is only referenced, not shipped.LICENSE.mdis Apache-2.0 for all source and content, with a separate proprietary licence for the MongoDB Agent binary. Only the CRD is shipped, so no proprietary content is included. TheLICENSEtext says so explicitly.Follow-ups outside this repo
oplugins-op/deploy/cert-manager/cert-manager.yaml(operator repo) had the upstream# Copyright 2022 The cert-manager Authors.header removed and replaced with the ASF header. The four copies inopluginsretained it. Apache-2.0 §4(c) requires keeping the notice, so that file needs a fix inapache/openserverless-operator.oplugins-op/LICENSEshould carry the same section, since the operator ships the same files on its own.LICENSE/NOTICErefers readers to aWARNfile thatno-release.txtstrips from the source tarball.Not in scope here: the pre-built JS bundles under
oplugins/utilandoplugins/admin/usageembed MIT/ISC/BSD npm packages that are attributed only inoplugins/NOTICE, not the top-levelLICENSE.🤖 Generated with Claude Code