Skip to content

Remove obsolete MinIO config calls and propagate setup errors in S3 tests - #17

Merged
sciabarracom merged 1 commit into
apache:0.9.0from
miki3421:fix-0.9.0-s3-test-config-errors
Oct 22, 2026
Merged

sciabarracom merged 1 commit into
apache:0.9.0from
miki3421:fix-0.9.0-s3-test-config-errors

Conversation

@miki3421

Copy link
Copy Markdown
Contributor

Problem and change

The system SeaweedFS and static tests still call ops config disable --minio, although the current config parser no longer accepts --minio. Both scripts ignore that failure, print config usage and can still finish with SUCCESS.

Remove those two obsolete calls. Explicitly exit with the original failing status when ops config enable or ops update apply fails. Keep the remaining test logic unchanged; no global shell error-mode change is introduced.

Validation

  • Bash syntax and git diff --check pass.
  • Four injected-error scenarios pass: config failure and update failure in each script. The original error status is propagated, no later command executes, and no SUCCESS is emitted.
  • Both patched scripts were executed on the existing synthetic K3s baseline. Neither emitted a config Usage block; configuration and update completed successfully.
  • 5-sys-seaweedfs.sh passed with exit 0 and confirmed the SeaweedFS provider/data bucket.
  • 7-static.sh k3s created the user and reached the static page with HTTP 200, but ended with exit 1 because its existing exact landing-page phrase is absent from the current page (title: Welcome to Apache OpenServerless). The unchanged assertion expects Welcome to Apache OpenServerless (incubating) static content distributor landing page!!!. That independent content/assertion mismatch is not fixed here, so this is not a claim that the full static test passes.

Only the two requested scripts are changed. No changes were made on amdtest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants