Repository navigation
Remove obsolete MinIO config calls and propagate setup errors in S3 tests - #17
Merged
sciabarracom merged 1 commit intoOct 22, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
The system SeaweedFS and static tests still call
ops config disable --minio, although the current config parser no longer accepts--minio. Both scripts ignore that failure, print config usage and can still finish with SUCCESS.Remove those two obsolete calls. Explicitly exit with the original failing status when
ops config enableorops update applyfails. Keep the remaining test logic unchanged; no global shell error-mode change is introduced.Validation
git diff --checkpass.5-sys-seaweedfs.shpassed with exit 0 and confirmed the SeaweedFS provider/data bucket.7-static.sh k3screated the user and reached the static page with HTTP 200, but ended with exit 1 because its existing exact landing-page phrase is absent from the current page (title: Welcome to Apache OpenServerless). The unchanged assertion expectsWelcome to Apache OpenServerless (incubating) static content distributor landing page!!!. That independent content/assertion mismatch is not fixed here, so this is not a claim that the full static test passes.Only the two requested scripts are changed. No changes were made on amdtest.