Repository navigation
Scope anonymous S3 access to web buckets on 0.9.0 - #139
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace unrestricted anonymous read access with grants scoped to declared web buckets. Reconcile legacy grants, reject web/data bucket name overlap, and require successful anonymous-access revocation before deleting a web bucket. A revoked web bucket must not expose data if its name is later reused.
Validation on an isolated 0.9.0 lab with SeaweedFS 3.97: anonymous data GET/Range changed from HTTP 200/206 to 403; web GET/Range remain 200/206; authenticated owner reads and writes pass. Both S3 and tenant ingress paths were checked. Deleting a web bucket and recreating it as private data denies anonymous access while other web buckets remain available. Ten focused unit tests passed, including fail-closed revocation. Alpha's five data-service checks passed.
Existing-state validation explicitly ran anonymous grant reconciliation. Deployment must run reconciliation for existing state and verify access; publishing an updated image alone does not prove remediation.