Repository navigation
Fixed more maven related editor kits on JDK 27 - #9713
Merged
Merged
Conversation
mbien
added
Maven
mbien
marked this pull request as draft
October 13, 2026 20:17
Member
Author
|
something wrong. investigating edit: it doesn't like the html kits. will revert those since they work by default |
this should cover all editor kits of the maven modules kits are no longer injected and can't be set via Strings (apache#9523)
mbien
force-pushed
the
fix-more-maven-editor-kits
branch
from
October 13, 2026 20:23
ed013de to
78c3efe
Compare
mbien
marked this pull request as ready for review
October 13, 2026 20:24
neilcsmith-net
approved these changes
Oct 14, 2026
neilcsmith-net
left a comment
neilcsmith-net
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks!
Yes, we need a wider effort to remove the broken registration and bring everything into alignment, but that should wait for NB33.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kits are no longer injected and can't be set via Strings
found the POM I missed in #9705 and several properties
the property editors are found in the run configuration windows for example, xml views are artifact details tabs
we should do a repo wide code inspection but I don't have time for that atm (also some of those are in guarded sections + require dependency changes)
meta #9523