Repository navigation
Conversation
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: no. Summary: The query-limit, Text2GQL, session, Clone Schema, quota, Vermeer and metadata claims match hugegraph-toolchain and hugegraph master, and all images, fixture digests and anchors resolve. Three added sentences anchor behaviour to a point in time or omit a version requirement, and the audit note points at an uncommitted artifact.
…nt inheritance contracts
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: no. Summary: The query-limit, Text2GQL, session, Clone Schema, quota, Vermeer and H2 metadata claims match hugegraph-toolchain and hugegraph master, the four comments from the earlier head are fixed, and all images, digests and anchors resolve. Two added passages name UI labels that Hubble does not show.
imbajin
left a comment
There was a problem hiding this comment.
Score: 6.5/10 · Confidence: high
Blocking: yes
Summary
The new browser test leaves the PR artifact, and the linked Vermeer guide understates the supported algorithm catalog. Existing UI label corrections also remain applicable.
Evidence
Reviewed the test origin and canonical URL configuration, guide text, Hubble adapter allowlist and frontend translations.
Validation notes
Source inspection only; browser tests and a live Hubble/Vermeer deployment were not run.
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: yes. Summary: The query-limit, H2 metadata, Text2GQL, session, quota, Clone Schema and UI label claims match hugegraph-toolchain and hugegraph master, and the eight earlier comments are fixed at this head. The expanded Vermeer catalog names fast_louvain, which Hubble rejects, instead of louvain_weighted.
| | `pagerank.diff_threshold` | Convergence threshold | `0.00001` | | ||
|
|
||
| Current Hubble accepts `pagerank`, `wcc`, `lpa`, `degree`, `closeness_centrality`, `betweenness_centrality`, `triangle_count`, `kcore`, and `sssp`. | ||
| The Hubble direct adapter accepts 19 algorithms: `pagerank`, `ppr`, `wcc`, `scc`, `lpa`, `slpa`, `degree`, `closeness_centrality`, `betweenness_centrality`, `triangle_count`, `kcore`, `sssp`, `clustering_coefficient`, `depth`, `cycle_detection`, `louvain`, `fast_louvain`, `kout`, and `jaccard`. |
There was a problem hiding this comment.
Important: DirectVermeerService.compute does not accept fast_louvain, so a request with it fails with Unsupported Vermeer algorithm, and the accepted louvain_weighted goes unlisted. Replace fast_louvain with louvain_weighted here and at line 463 of the CN guide.
| Degree Centrality, Closeness Centrality, Betweenness Centrality, Triangle Count, K-Core, and Single-Source Shortest Path (SSSP). | ||
| - **Algorithm catalog**: The direct adapter supports 19 algorithms, including PageRank/PPR, WCC/SCC, LPA/SLPA, | ||
| centrality, Triangle Count, K-Core, SSSP, Clustering Coefficient, Depth, Cycle Detection, Louvain variants, K-out and Jaccard. | ||
| Select the form for the current engine; parameters and property-filter restrictions are listed in the Vermeer guide. |
There was a problem hiding this comment.
Minor: the Vermeer guide lists no property-filter restrictions, so this pointer leads nowhere, here and at CN line 335. Add to section 2.4 of the Vermeer guide, in both languages, that Hubble rejects filter.vertex_expr / filter.edge_expr for cycle_detection and louvain.edge_weight_property for louvain_weighted, or drop the pointer.
| returned by PD, and ensure targets are in `operations.store.allowed_targets`. A partially available overview indicates metrics collection was blocked for | ||
| specific sources, not that graph APIs are down. | ||
|
|
||
| When `pd.server` names a Service or proxy that cannot identify one member, its process metrics remain a **configured endpoint sample**. |
There was a problem hiding this comment.
Minor: the diagnostics label is Configured PD endpoint sample (CN 配置的 PD 端点样本), so readers will not find configured endpoint sample here or 【配置端点采样】 at CN line 245. Use the hubble-fe i18n labels in both files.
imbajin
left a comment
There was a problem hiding this comment.
Score: 7.0/10 · Confidence: high
Blocking: yes
Summary
The catalog names an unsupported algorithm and omits a supported one; the linked filter restrictions and diagnostics label also need correction. No additional actionable findings were identified.
Evidence
Compared the bilingual diff with DirectVermeerService's allowlist and filter validation and with frontend translations.
Validation notes
Source review only; browser tests and live Hubble/Vermeer workflows were not independently run.
Purpose of the PR
Bring the English and Chinese Hubble guides and screenshots into line with the current application, so users can deploy, import, query and recover from common failures without relying on old UI behavior.
Validation: source checks, strict build, independent artifact/link checks and desktop/mobile interaction checks passed. Real standalone import/count and authenticated minimal Helm workflows are recorded in the screenshot fixtures. Original-image viewing, keyboard focus and mobile layout were checked.
The theme is already OINK 1.5.1; this PR changes content and reuses its public components.