Repository navigation
Conversation
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: no. Summary: The locked SDK lookup, the master rejection in checkout-server.sh, Spark 3.5.8/Scala 2.12.18/Guava 30.0-jre, nullable compute quotas, graph-clone and per-source Loader resume text match Toolchain and Server master. One version gap in the GraphSpace section, in both languages.
…mpute quotas and storage metrics
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: yes. Summary: The locked SDK lookup, candidate build flags, Spark 3.5.8/Scala 2.12.18/Guava 30.0-jre, nullable compute quotas, graph-clone, help <command> and per-source Loader resume text match Toolchain and Server master, and the earlier 8.3 version comment is fixed in prose. The Spark 3.2 test command also runs the Client API tests, which clear a hardcoded local graph, and the getStorageUsedKb() table row still lacks its version note.
… getStorageUsedKb
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: no. Score: 9/10. Summary: The locked SDK lookup, master rejection and the Tools, Loader, Client and Spark Connector commands all build as written against Toolchain master, and the Spark 3.5.8/Scala 2.12.18, nullable compute quota, per-source resume and help <command> text match the source; the three earlier comments are fixed in both languages.
imbajin
left a comment
There was a problem hiding this comment.
Score: 7.5/10 · Confidence: high
Blocking: yes
Summary
The quota update table promises omission even for a fetched GraphSpace whose fields are already populated. Resending a stale object can overwrite a concurrent quota change.
Evidence
GraphSpaceAPI.get deserializes the response, and GraphSpaceReq copies non-null compute quotas into the update request. The earlier Spark and version comments are addressed at this head.
Validation notes
Source inspection only; no live quota update, full SDK build, Spark deployment, or Loader recovery was run.
|
|
||
| | 更新 GraphSpace 时的操作 | 结果 | | ||
| | --- | --- | | ||
| | 不调用 `setComputeCpuLimit` / `setComputeMemoryLimit` | 请求省略该字段,保留原值 | |
There was a problem hiding this comment.
This is only true while the fields are unset. A GraphSpace returned by GraphSpaceAPI.get() can already contain compute limits from the response; GraphSpaceReq copies those non-null values into the update even if the application never calls either setter. Updating a previously fetched object can therefore resend stale limits and overwrite a concurrent quota change. Please qualify the table for unset fields and explain that fetched objects may resend their existing values; the English table needs the same correction. This is based on source inspection; I did not run a live update.
Purpose of the PR
Fix Toolchain instructions that fail against current source builds and clarify what import recovery actually preserves.
Validation: executable shell/JSON checks, locked-SDK lookup, source-contract review and independent artifact checks passed. Desktop/mobile checks verified complete code copying, native tables, keyboard focus and touch behavior. Legacy anchors are preserved.