Skip to content

mod_cache_socache: Keep the body when a revalidated entry is refreshed. - #863

Open
arturobernalg wants to merge 1 commit into
apache:trunkfrom
arturobernalg:fix/httpd-62493-socache-304-body
Open

arturobernalg wants to merge 1 commit into
apache:trunkfrom
arturobernalg:fix/httpd-62493-socache-304-body

Conversation

@arturobernalg

@arturobernalg arturobernalg commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

A 304 response updates the headers of the stored response, but store_headers() rebuilt the entry without the body recalled by open_entity(), so later requests were answered from the cache with the headers and an empty body. Copy the body into the new entry, or drop the entry when it no longer fits.

PR 62493.


  • This PR does not report or address a security vulnerability
    (see SECURITY.md and
    https://www.apache.org/security/#reporting-a-vulnerability).
  • Code follows the httpd style guide.
  • New log messages (level debug or higher) use an empty APLOGNO() tag;
    numbers are assigned by a committer at merge time (see docs/log-message-tags/README).
  • If the change is user-visible, a changes-entries/*.txt file is included,
    following the template in README.CHANGES (not needed otherwise).
  • Test cases based on pyhttpd are included where appropriate, in the
    test/modules/xxx directory matching the modules/xxx module source,
    or test/modules/core for core server changes. On Unix, verify these
    pass locally with e.g. make check-pytest PYTEST_DIRS=test/modules/xxx.

A 304 response updates the headers of the stored response, but
store_headers() rebuilt the entry without the body recalled by
open_entity(), so later requests were answered from the cache with the
headers and an empty body. Copy the body into the new entry, or drop
the entry when it no longer fits.

PR 62493.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant