Repository navigation
Show the result of all optimizer passes in EXPLAIN VERBOSE #759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
99d7ff4
Remove old optimize_for_explain plumbing
alamb f78fe0d
Show plans that are no different than the previous as "SAME"
alamb 266d1fa
Add all physical optimizer passes
alamb a1d5a4a
tests
alamb a9dcd65
cleanup
alamb 8a97e07
fix user_defined_plan test
alamb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,7 +23,6 @@ use crate::execution::context::ExecutionProps; | |
| use crate::logical_plan::LogicalPlan; | ||
| use crate::optimizer::optimizer::OptimizerRule; | ||
| use std::sync::Arc; | ||
| use utils::optimize_explain; | ||
|
|
||
| /// Optimization rule that tries pushes down LIMIT n | ||
| /// where applicable to reduce the amount of scanned / processed data | ||
|
|
@@ -43,25 +42,6 @@ fn limit_push_down( | |
| execution_props: &ExecutionProps, | ||
| ) -> Result<LogicalPlan> { | ||
| match (plan, upper_limit) { | ||
| ( | ||
| LogicalPlan::Explain { | ||
| verbose, | ||
| schema, | ||
| plan, | ||
| stringified_plans, | ||
| }, | ||
| _, | ||
| ) => { | ||
| let schema = schema.as_ref().to_owned().into(); | ||
| optimize_explain( | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is the old style "explain" implementation that needed to be done for each optimizer for it to correctly show explain plans (and it was missing from several) |
||
| optimizer, | ||
| *verbose, | ||
| plan, | ||
| stringified_plans, | ||
| &schema, | ||
| execution_props, | ||
| ) | ||
| } | ||
| (LogicalPlan::Limit { n, input }, upper_limit) => { | ||
| let smallest = upper_limit.map(|x| std::cmp::min(x, *n)).unwrap_or(*n); | ||
| Ok(LogicalPlan::Limit { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Now we have the optimized plan displayed