Repository navigation
Fix required partitioning of Single aggregation mode - #6950
Conversation
|
FYI @mingmwang |
|
According to With the proposed changes, Will this requirement add |
|
I think the purpose of this PR is to extend the use case of |
Ah I missed that part. Currently the optimization rule runs after the |
|
I added a mode |
mustafasrepo
left a comment
There was a problem hiding this comment.
Thanks @Dandandan for this PR.
Which issue does this PR close?
Closes #6949
Rationale for this change
Fix a small issue in this aggregation mode .
Currently the
Singlemode returnsUnspecifiedDistributionas required distribution, which is not correct. If we would re-optimize / change the plan, it could cause the plan to return incorrect results. This currently is not the case in DataFusion as we rely on the fact that required distribution is already satisfied and we don't modify that part of the plan.What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?