Skip to content

Reduce code / allocations when printing Exprs - #6739

Closed
alamb wants to merge 2 commits into
apache:mainfrom
alamb:alamb/comma_strings
Closed

alamb wants to merge 2 commits into
apache:mainfrom
alamb:alamb/comma_strings

Conversation

@alamb

@alamb alamb commented Jun 21, 2023

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Related to #6677

Rationale for this change

Using a macro to format Vec's of Exprs adds more code and it does a bunch of allocations (both String and Vec) that we can avoid.

See #6708 (comment) for more context

What changes are included in this PR?

Change macro to functions and impl Display

cc @parkma99

Are these changes tested?

Yes, by existing tests

Are there any user-facing changes?

@github-actions github-actions Bot added the logical-expr Logical plan and expressions label Jun 21, 2023
@alamb
alamb marked this pull request as draft June 21, 2023 18:11
@github-actions github-actions Bot added physical-expr Changes to the physical-expr crates sql SQL Planner labels Jun 21, 2023

@alamb alamb left a comment •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parkma99 I wonder if you have any thoughts on this approach? I am not super happy with it

@alamb alamb mentioned this pull request Jun 21, 2023
@parkma99

Copy link
Copy Markdown
Contributor

I am a beginner of Rust. I have no thoughts on this.😊

@tustvold
tustvold changed the base branch from main to backup-main June 27, 2023 11:13
@tustvold
tustvold changed the base branch from backup-main to main June 27, 2023 11:13
@alamb

alamb commented Jul 25, 2023

Copy link
Copy Markdown
Contributor Author

I have no plans to pursue this PR at this time, so closing it

@alamb alamb closed this Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates sql SQL Planner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants