Repository navigation
Conversation
alamb
marked this pull request as draft
June 21, 2023 18:11
Merged
Contributor
|
I am a beginner of Rust. I have no thoughts on this.😊 |
Contributor
Author
|
I have no plans to pursue this PR at this time, so closing it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #6677
Rationale for this change
Using a macro to format Vec's of Exprs adds more code and it does a bunch of allocations (both
StringandVec) that we can avoid.See #6708 (comment) for more context
What changes are included in this PR?
Change macro to functions and
impl Displaycc @parkma99
Are these changes tested?
Yes, by existing tests
Are there any user-facing changes?