Skip to content

Move protoc generation to binary crate (#5718) - #5742

Merged
alamb merged 5 commits into
apache:mainfrom
l0kr:move-protoc-to-gen-script
Mar 27, 2023
Merged

alamb merged 5 commits into
apache:mainfrom
l0kr:move-protoc-to-gen-script

Conversation

@l0kr

@l0kr l0kr commented Mar 26, 2023

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes #5718

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@tustvold

Copy link
Copy Markdown
Contributor

Comment thread datafusion/proto/gen/Cargo.toml Resolved
@l0kr

l0kr commented Mar 26, 2023

Copy link
Copy Markdown
Contributor Author

Could we get a CI check, similar to https://github.com/apache/arrow-rs/pull/3927/files#diff-7a5f24a0bed6232c2297eba93812cdaeb26327ba955eabc0a04effc21e95d52bR65

Should I create another yaml or add check to existing one?

@tustvold

Copy link
Copy Markdown
Contributor

I think adding it to https://github.com/apache/arrow-datafusion/blob/main/.github/workflows/rust.yml would make sense

uses: ./.github/actions/setup-builder
- name: Run gen
run: ./regen.sh
working-directory: ./datafusion/proto

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part shouldn't be necessary, as the script already handles this, but I suppose it can't hurt

@alamb

alamb commented Mar 27, 2023

Copy link
Copy Markdown
Contributor

I verified this works great -- #5760 (comment)

Thanks @tustvold and @l0kr

@alamb
alamb merged commit dda2c20 into apache:main Mar 27, 2023
tokio = "1.18"

[build-dependencies]
# Pin these dependencies so that the generated output is deterministic

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move protoc generation to binary crate

3 participants