You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
apache/arrow-rs#3633 added the ability to push down limits to the parquet reader. This is particularly important when filter pushdown is enabled on ParquetOptions (soon to be default), as it allows the limit to be applied before late materialization, which has significant performance benefits
The reason will be displayed to describe this comment to others. Learn more.
Thank you @tustvold -- it would be nice to have a test for this, but I am not sure there is any way to test this really (other than performance benchmarks).
Thank you @tustvold -- it would be nice to have a test for this, but I am not sure there is any way to test this really (other than performance benchmarks).
There is tpch in the current benchmarks, may we consider adding clickbench?
There is tpch in the current benchmarks, may we consider adding clickbench?
It is a good idea @jackwener -- I have it on my list this week to do some more organizing related to benchmarking. I definitely agree that clickbench would be super helpful
Benchmark runs are scheduled for baseline = 58cd1bf and contender = 4118076. 4118076 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Relates to #5404
Rationale for this change
apache/arrow-rs#3633 added the ability to push down limits to the parquet reader. This is particularly important when filter pushdown is enabled on
ParquetOptions(soon to be default), as it allows the limit to be applied before late materialization, which has significant performance benefitsWhat changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?