Skip to content

Parquet limit pushdown (#5404) - #5416

Merged
alamb merged 1 commit into
apache:mainfrom
tustvold:parquet-limit-pushdown
Feb 27, 2023
Merged

alamb merged 1 commit into
apache:mainfrom
tustvold:parquet-limit-pushdown

Conversation

@tustvold

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Relates to #5404

Rationale for this change

apache/arrow-rs#3633 added the ability to push down limits to the parquet reader. This is particularly important when filter pushdown is enabled on ParquetOptions (soon to be default), as it allows the limit to be applied before late materialization, which has significant performance benefits

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tustvold -- it would be nice to have a test for this, but I am not sure there is any way to test this really (other than performance benchmarks).

@jackwener jackwener left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice job. Thank you @tustvold

@jackwener

jackwener commented Feb 27, 2023 •

Copy link
Copy Markdown
Member

Thank you @tustvold -- it would be nice to have a test for this, but I am not sure there is any way to test this really (other than performance benchmarks).

There is tpch in the current benchmarks, may we consider adding clickbench?

@alamb

alamb commented Feb 27, 2023

Copy link
Copy Markdown
Contributor

There is tpch in the current benchmarks, may we consider adding clickbench?

It is a good idea @jackwener -- I have it on my list this week to do some more organizing related to benchmarking. I definitely agree that clickbench would be super helpful

@alamb
alamb merged commit 4118076 into apache:main Feb 27, 2023
@ursabot

ursabot commented Feb 27, 2023

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 58cd1bf and contender = 4118076. 4118076 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants