Repository navigation
Add missing protobuf serialisation functionality GetIndexedFieldExpr. - #5324
Conversation
This is required in order for `ballista` to serialise the indexing expressions for nested lists. Otherwise, `ballista` cannot execute any SQL that contains indexing expressions.
alamb
left a comment
There was a problem hiding this comment.
Looks like a great addition to me -- thank you @ahmedriza
|
I merged this soon as I don't think it is controversial. I am happy to make changes or back it out if any maintainer feels differently |
|
Benchmark runs are scheduled for baseline = d6d9c6f and contender = c5108ae. c5108ae is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
…apache#5324) This is required in order for `ballista` to serialise the indexing expressions for nested lists. Otherwise, `ballista` cannot execute any SQL that contains indexing expressions.
This is required in order for
ballistato serialise the indexing expressions for nested lists. Otherwise,ballistacannot execute any SQL that contains indexing expressions.Which issue does this PR close?
Closes #5323
Rationale for this change
Add missing protobuf serialisation for
GetIndexedFieldExprthat is required when running queries that index nested structures.What changes are included in this PR?
Add protobuf serialisation for
GetIndexedFieldExprand a unit test.Are these changes tested?
Yes
Are there any user-facing changes?
No