Skip to content

Fix broken CI on git diff: Not a git repository - #5182

Closed
viirya wants to merge 1 commit into
apache:masterfrom
viirya:try_fix_ci
Closed

viirya wants to merge 1 commit into
apache:masterfrom
viirya:try_fix_ci

Conversation

@viirya

@viirya viirya commented Feb 4, 2023 •

Copy link
Copy Markdown
Member

Which issue does this PR close?

Closes #5180.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@viirya viirya changed the title Fix CI CI is currently broken on git diff: Not a git repository Feb 4, 2023
@viirya

viirya commented Feb 4, 2023

Copy link
Copy Markdown
Member Author

This fix is verified to work, please see https://github.com/apache/arrow-datafusion/actions/runs/4093817150/jobs/7059519148.

@viirya viirya changed the title CI is currently broken on git diff: Not a git repository Fix broken CI on git diff: Not a git repository Feb 4, 2023
@viirya viirya changed the title Fix broken CI on git diff: Not a git repository Fix broken CI on git diff: Not a git repository Feb 4, 2023
@tustvold

tustvold commented Feb 5, 2023

Copy link
Copy Markdown
Contributor

Perhaps I'm biased, but I think #5177 is cleaner

@jackwener

jackwener commented Feb 5, 2023 •

Copy link
Copy Markdown
Member

After merge #5177, look like we can close this.
Thanks @tustvold and @viirya ❤️

@jackwener jackwener closed this Feb 5, 2023
@viirya
viirya deleted the try_fix_ci branch February 5, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI is currently broken on git diff: Not a git repository

3 participants