Skip to content

[sqllogictests] Port orderby.rs to sqllogictests - #5062

Merged
alamb merged 5 commits into
apache:masterfrom
alamb:alamb/port_order_tests
Jan 26, 2023
Merged

alamb merged 5 commits into
apache:masterfrom
alamb:alamb/port_order_tests

Conversation

@alamb

@alamb alamb commented Jan 25, 2023

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Part of #4495

Rationale for this change

I am about to write tests for #4854 and wanted to use sqllogictests so I figured I would start by porting the existing orderby tests to sqllogictests

What changes are included in this PR?

  1. Port orderby.rs test to sqllogictest

Are these changes tested?

Yes

Are there any user-facing changes?

No

@alamb alamb added the development-process Related to development process of DataFusion label Jan 25, 2023
@github-actions github-actions Bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) and removed development-process Related to development process of DataFusion labels Jan 25, 2023
@@ -0,0 +1,11 @@
0,0,true

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I captured this data by copying the result of running the code in https://github.com/apache/arrow-datafusion/blob/4a33f2708fe8e30f5f9b062a097fc6155f2db2ce/datafusion/core/tests/sql/partitioned_csv.rs#L47-L73

I think it is easier to understand what is going on if the files are checked in rather than auto generated

@alamb alamb mentioned this pull request Jan 25, 2023
3 tasks done

@melgenek melgenek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, assuming that sort_with_lots_of_repetition_values is supposed to be removed.

Comment on lines -217 to -221
let filename = "tests/parquet/data/repeat_much.snappy.parquet";

ctx.register_parquet("rep", filename, ParquetReadOptions::default())
.await?;
let sql = "select a from rep order by a";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this test be moved to .slt as well?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I am not sure how I missed this . Thank you for the catch. It appears to have a pretty massive output that is not easy to replicate in slt, so I will leave it in rust for now.

05fb049

@alamb
alamb merged commit d588b47 into apache:master Jan 26, 2023
@alamb
alamb deleted the alamb/port_order_tests branch January 26, 2023 19:19
@ursabot

ursabot commented Jan 26, 2023

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 556fffb and contender = d588b47. d588b47 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants