Skip to content

Remove Confusing "Bare" in does not exist messages - #4572

Merged
xudong963 merged 2 commits into
apache:masterfrom
alamb:alamb/cleanup_error_messages
Dec 10, 2022
Merged

xudong963 merged 2 commits into
apache:masterfrom
alamb:alamb/cleanup_error_messages

Conversation

@alamb

@alamb alamb commented Dec 9, 2022

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes #4571

Rationale for this change

I think #4530 made error messages look much crappier. For example:

Table Bare \{ table: "user" \} doesn't exist.

I noticed this while adding errors in #4535

I would like the messages to only have the table name (not the Debug version of OwnedTableReference).

What changes are included in this PR?

  1. Improve error messages to not have Bare
  2. Update tests
  3. Drive by improvement to change an InternalError to an execution error

Are these changes tested?

Yes

Are there any user-facing changes?

Better error messages

@github-actions github-actions Bot added core Core DataFusion crate sql SQL Planner sqllogictest SQL Logic Tests (.slt) labels Dec 9, 2022

# Can not drop it again
statement error Table Bare \{ table: "user" \} doesn't exist.
statement error Table 'user' doesn't exist.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can see the result of the changes in this file ❤️

@xudong963

Copy link
Copy Markdown
Member

This is a clear improvement, merged!

@xudong963
xudong963 merged commit 4b6ff8d into apache:master Dec 10, 2022
@alamb
alamb deleted the alamb/cleanup_error_messages branch December 10, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate sql SQL Planner sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confusing "Bare" in doesn't exist messages

2 participants