Skip to content

Template change - #4114

Merged
andygrove merged 2 commits into
apache:masterfrom
spaceandtimefdn:bg_template
Nov 7, 2022
Merged

andygrove merged 2 commits into
apache:masterfrom
spaceandtimefdn:bg_template

Conversation

@avantgardnerio

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes #4113.

Rationale for this change

Make it explicit that all PRs should have tests, and force developers to at least ponder why they don't have one.

What changes are included in this PR?

A change to the PR template.

Are there any user-facing changes?

They will be reminded that testing is required.

@github-actions github-actions Bot added the development-process Related to development process of DataFusion label Nov 5, 2022

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @avantgardnerio -- love it

Comment thread .github/pull_request_template.md Resolved
@alamb
alamb requested a review from andygrove November 6, 2022 11:53
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>

@xudong963 xudong963 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good! --- This will reduce the frequency with which maintainers remind contributors to add tests.

@andygrove
andygrove merged commit 531dfdc into apache:master Nov 7, 2022
@ursabot

ursabot commented Nov 7, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = b9eee50 and contender = 531dfdc. 531dfdc is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of DataFusion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add test field to PR template

5 participants