Repository navigation
remove type coercion for physical ScalarFunction - #3749
Conversation
| input_schema: &Schema, | ||
| execution_props: &ExecutionProps, | ||
| ) -> Result<Arc<dyn PhysicalExpr>> { | ||
| let coerced_phy_exprs = |
There was a problem hiding this comment.
remove type coercion in the physical phase
| }; | ||
| Ok(expr) | ||
| } | ||
| Expr::ScalarUDF { fun, args } => { |
There was a problem hiding this comment.
just move these code
60e1787 to
b9799e0
Compare
type coercion for ScalarFunctiontype coercion for ScalarFunction
type coercion for ScalarFunctiontype coercion for physical ScalarFunction
|
The CI checks appear to be failing |
b9799e0 to
00f2d31
Compare
Some errors about import in the test, I have fixed them PTAL @alamb |
|
I will merge it first, and not block the follow-up pr. |
|
Benchmark runs are scheduled for baseline = e54110f and contender = a92119a. a92119a is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
alamb
left a comment
There was a problem hiding this comment.
Looks good to me -- thanks @liukun4515
| } | ||
|
|
||
| // Helper function | ||
| // The type coercion will be done in the logical phase, should do the type coercion for the test |
There was a problem hiding this comment.
👍
BTW this is basically what I need to do in IOx / why I made #3708
Which issue does this PR close?
Closes #3731
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?