Skip to content

delete type coercion for scalar udf in the physical phase - #3735

Merged
alamb merged 1 commit into
apache:masterfrom
liukun4515:issue_#3734
Oct 6, 2022
Merged

alamb merged 1 commit into
apache:masterfrom
liukun4515:issue_#3734

Conversation

@liukun4515

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes #3734

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@liukun4515
liukun4515 requested a review from alamb October 6, 2022 14:29
@liukun4515

Copy link
Copy Markdown
Contributor Author

@alamb remove type coercion in the physical phase

@liukun4515

Copy link
Copy Markdown
Contributor Author

@alamb PTAL

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me -- thanks @liukun4515

@alamb

alamb commented Oct 6, 2022

Copy link
Copy Markdown
Contributor

CI failure appears unrelated: #3743

@alamb
alamb merged commit 88eadc4 into apache:master Oct 6, 2022
@ursabot

ursabot commented Oct 6, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 7c5c2e5 and contender = 88eadc4. 88eadc4 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove type coercion for ScalarUDF in the physical phase

3 participants