Skip to content

Update sqlparser to 0.24.0 - #3675

Merged
alamb merged 2 commits into
apache:masterfrom
alamb:alamb/update_sqlparser
Oct 3, 2022
Merged

alamb merged 2 commits into
apache:masterfrom
alamb:alamb/update_sqlparser

Conversation

@alamb

@alamb alamb commented Oct 1, 2022 •

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Re #3606

(based off dependabot #3654)

Rationale for this change

Upgrade to get support for explain plan format (e.g. explain graphviz)

What changes are included in this PR?

  1. Upgrade dependency
  2. Update code to use new code

Are there any user-facing changes?

No

dependabot Bot and others added 2 commits September 29, 2022 08:32
Updates the requirements on [sqlparser](https://github.com/sqlparser-rs/sqlparser-rs) to permit the latest version.
- [Release notes](https://github.com/sqlparser-rs/sqlparser-rs/releases)
- [Changelog](https://github.com/sqlparser-rs/sqlparser-rs/blob/main/CHANGELOG.md)
- [Commits](apache/datafusion-sqlparser-rs@v0.23.0...v0.24.0)

---
updated-dependencies:
- dependency-name: sqlparser
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@github-actions github-actions Bot added core Core DataFusion crate logical-expr Logical plan and expressions sql SQL Planner labels Oct 1, 2022
verbose,
statement,
analyze,
format: _,

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here is the support for explain plan format

SQLExpr::Value(Value::Interval {
SQLExpr::Array(arr) => self.sql_array_literal(arr.elem, schema),

SQLExpr::Interval {

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intervals are no longer literals (Value) but can have exprs so the AST was updated to match in apache/datafusion-sqlparser-rs#609

@alamb
alamb requested a review from Dandandan October 1, 2022 11:18
@xudong963

Copy link
Copy Markdown
Member

@alamb

alamb commented Oct 1, 2022 •

Copy link
Copy Markdown
Contributor Author

https://github.com/apache/arrow-datafusion/actions/runs/3164334070/jobs/5152557761

Other PRs also encountered the issue :/

🤔 maybe we have hit the disk space limit on the github builders (14GB maybe?)

@alamb

alamb commented Oct 2, 2022

Copy link
Copy Markdown
Contributor Author

Filed #3678 for the CI failure

@alamb
alamb merged commit f706902 into apache:master Oct 3, 2022
@ursabot

ursabot commented Oct 3, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = c9b26cc and contender = f706902. f706902 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate logical-expr Logical plan and expressions sql SQL Planner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants