Repository navigation
fix(expr): Rename aliases in set expression to the left side schema field to avoid duplicate field name errors - #27473
Merged
Conversation
AdamGS
force-pushed
the
adamg/set-expr-duplicate-aliases
branch
from
November 16, 2026 12:52
8849c70 to
5663378
Compare
alamb
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Ran into this issue while working on #27380, and the motivating case here is aliases like
count(1) AS "count(*), which is even mentioned in the call site indatafusion/sql/src/select.rs. I've also found the already existing issue mentioned above.What changes are included in this PR?
Instead of keeping aliases as they are, we also rename them to the left side's schema field name.
What is the testing strategy for this PR?
Added dedicated SLT cases, which I've also verified against DuckDB.
Are there any user-facing changes?
Should only enable new cases.