Repository navigation
test: split leaf_pushdown_fuzz_extended into parallel sub-tests (#26759) - #26902
Merged
Merged
Conversation
Contributor
Author
|
CC @2010YOUY01 what are ur opinion's? |
Sruhvx-jpg
marked this pull request as draft
November 10, 2026 20:06
blaginin
self-requested a review
November 18, 2026 17:57
blaginin
marked this pull request as ready for review
November 18, 2026 17:57
Member
|
this seems important because that's one of the slowest test which sometimes result in the CI bottleneck |
blaginin
approved these changes
Nov 18, 2026
blaginin
enabled auto-merge
November 18, 2026 18:20
0xdeafbeef
pushed a commit
to 0xdeafbeef/datafusion
that referenced
this pull request
Nov 19, 2026
extended tests were unnecessarily [slow](https://github.com/apache/datafusion/actions/runs/44326404502/job/134878743321#step:11:812) because of just two tests <img width="1090" height="476" alt="file-0b04021c474b008e850fda968749cfe6" src="https://github.com/user-attachments/assets/5aa8cefd-ab40-42cf-9016-b25525cdba36" /> One was fixed in apache#26902 This PR fixes the other one Before <img width="340" height="69" alt="dyn-ca6f6b73039acc8437b1a680875da51e" src="https://github.com/user-attachments/assets/1ece97ba-96b1-4667-bdcf-7b52e4d3d68d" /> After <img width="341" height="64" alt="dyn-c899d24cd91ec98c3da6e7dd60769886" src="https://github.com/user-attachments/assets/4a3f9d3d-8d8d-44ef-9a86-02dab0bd7902" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes part of #26759.
Rationale for this change
In CI extended runs,
leaf_pushdown_fuzz_extendedbottlenecks runners for ~230 seconds by sequentially running 5,000 in-memory cases followed by 1,000 Parquet cases on a single thread.Per maintainer feedback in #26843, this PR splits the extended test into smaller, parallel sub-tests rather than adding internal concurrency machinery.
What changes are included in this PR?
leaf_pushdown_fuzz_extendedinto 4 partitioned test targets (1,250 cases each with disjoint seed ranges).leaf_pushdown_fuzz_extended_parquet.async fn run(...)remains unchanged. Total case count and deterministic seed reproduction are fully preserved.Are these changes tested?
Yes, tested via
cargo test --features extended_tests --test extended_tests -- leaf_pushdown.