Repository navigation
Implement select distinct - #262
Merged
Merged
Conversation
Dandandan
commented
May 4, 2021
| &self, | ||
| input: &LogicalPlan, | ||
| expr: Vec<Expr>, | ||
| force: bool, |
Contributor
Author
There was a problem hiding this comment.
small drive-by simplification, an unused option
Codecov Report
@@ Coverage Diff @@
## master #262 +/- ##
==========================================
+ Coverage 76.80% 76.87% +0.06%
==========================================
Files 133 133
Lines 23284 23350 +66
==========================================
+ Hits 17884 17950 +66
Misses 5400 5400
Continue to review full report at Codecov.
|
alamb
approved these changes
May 4, 2021
alamb
left a comment
Contributor
There was a problem hiding this comment.
This looks great @Dandandan thank you ❤️
| let sql = "SELECT DISTINCT c1 FROM aggregate_simple order by c1"; | ||
| let actual = execute(&mut ctx, sql).await; | ||
|
|
||
| let expected = vec![ |
Contributor
There was a problem hiding this comment.
I doubled checked that the input has duplicates (to show that the distinct has removed them): https://github.com/apache/arrow-datafusion/blob/master/datafusion/tests/aggregate_simple.csv
👍
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
HairstonE
pushed a commit
to HairstonE/datafusion
that referenced
this pull request
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #250
Rationale for this change
Fix behavior and a simple implementation of select distinct.
What changes are included in this PR?
An implementation of select distinct.
Are there any user-facing changes?
A working select distinct