Skip to content

minor: validate config meta_fetch_concurrency when setting it - #23595

Merged
xudong963 merged 4 commits into
apache:mainfrom
2010YOUY01:cfg-meta-fetch-concurrency
Jul 16, 2026
Merged

xudong963 merged 4 commits into
apache:mainfrom
2010YOUY01:cfg-meta-fetch-concurrency

Conversation

@2010YOUY01

@2010YOUY01 2010YOUY01 commented Jul 15, 2026 •

Copy link
Copy Markdown
Member

Which issue does this PR close?

Rationale for this change

This is logically the same change as #23592, but for another configuration.

0 is an invalid value for concurrency level, so restricting it to be non-zero

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions Bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) catalog Related to the catalog crate common Related to common crate datasource Changes to the datasource crate labels Jul 15, 2026
@comphead
comphead added this pull request to the merge queue Jul 15, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Jul 15, 2026
@xudong963
xudong963 added this pull request to the merge queue Jul 16, 2026
Merged via the queue into apache:main with commit 1adbd84 Jul 16, 2026
37 checks passed
kosiew pushed a commit to kosiew/datafusion that referenced this pull request Aug 12, 2026
…he#23595)

## Which issue does this PR close?

<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes apache#123` indicates that this PR will close issue apache#123.
-->

- Part of apache#17498

## Rationale for this change

<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->
This is logically the same change as apache#23592, but for another
configuration.

0 is an invalid value for concurrency level, so restricting it to be
non-zero

## What changes are included in this PR?

<!--
There is no need to duplicate the description in the issue here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->

## Are these changes tested?

<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code

If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->

## Are there any user-facing changes?

<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->

<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

catalog Related to the catalog crate common Related to common crate core Core DataFusion crate datasource Changes to the datasource crate sqllogictest SQL Logic Tests (.slt) v55.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants